Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(js-libraries): hide fast path items from table, put all in debugData #10176

Merged
merged 9 commits into from
Jan 7, 2020

Conversation

connorjclark
Copy link
Collaborator

image

Fixes #9881

Don't think we need to put a secondary (or w/e) property in js-library-detector. A naming convention for the id is sufficient imo.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impl LGTM

I'm hoping the failed travis means we have some tests to update :)

lighthouse-core/audits/dobetterweb/js-libraries.js Outdated Show resolved Hide resolved
lighthouse-core/audits/dobetterweb/js-libraries.js Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview January 4, 2020 01:09 Inactive
@vercel vercel bot temporarily deployed to Preview January 7, 2020 02:00 Inactive
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connorjclark connorjclark merged commit 5dcb666 into master Jan 7, 2020
@connorjclark connorjclark deleted the stack-packs-dupes branch January 7, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated stack packs
3 participants