Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(installable-manifest): icon requirement 192px -> 144px #10175

Merged
merged 1 commit into from
Jan 15, 2020
Merged

core(installable-manifest): icon requirement 192px -> 144px #10175

merged 1 commit into from
Jan 15, 2020

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jan 3, 2020 •
edited
Loading

part 1 of #6700

@patrickhulce
Copy link
Collaborator

Has the

after double checking this is 👍 :)

part been satisfied? :)

This has been a very public and very vocal issue (inexplicably IMO 😆) for a long time to change without any PR description or link to how this was confirmed 😉

@connorjclark
Copy link
Collaborator Author

https://misc-hoten.surge.sh/lh-6700-manifest/index140.html
https://misc-hoten.surge.sh/lh-6700-manifest/index144.html
https://misc-hoten.surge.sh/lh-6700-manifest/index192.html

Chrome works for all but 140px. Firefox works for all of them.

@patrickhulce
Copy link
Collaborator

Oh good point. I interpreted @brendankenny's comment to mean it's been blessed by some mixture of PWA stakeholders elsewhere, but maybe he just meant testing functionality confirmation...

@paulirish
Copy link
Member

i looked at @dominickng's last comment (from ~13months ago) and verified in the source that 144 is still the case.

so we're good on the 192 -> 144 change, still.

@connorjclark
Copy link
Collaborator Author

Alls that left is some green checks :)

patrickhulce
patrickhulce approved these changes Jan 15, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then!

@connorjclark connorjclark changed the title core(installable-manifest): reduce icon requirement from 192px to 144px core(installable-manifest): icon requirement 192px -> 144px Jan 15, 2020
@connorjclark connorjclark changed the title core(installable-manifest): icon requirement 192px -> 144px core(installable-manifest): icon requirement 192px -> 144px Jan 15, 2020
@connorjclark connorjclark merged commit f145f84 into master Jan 15, 2020
@connorjclark connorjclark deleted the a2hs-manifest-144px branch January 15, 2020 22:13
@paulirish paulirish mentioned this pull request Apr 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @patrickhulce @paulirish @googlebot