Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): automated-lighthouse-check.com - paid / tiered #10156

Merged
merged 7 commits into from
Dec 30, 2019
Merged

docs(readme): automated-lighthouse-check.com - paid / tiered #10156

merged 7 commits into from
Dec 30, 2019

Conversation

adamhenson
Copy link
Contributor

Summary

Adds a bullet to the Paid / Tiered section of readme for Automated Lighthouse Check.

@adamhenson adamhenson changed the title docs(readme): paid / tiered - automated-lighthouse-check.com docs(readme): automated-lighthouse-check.com - paid / tiered Dec 28, 2019
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening @adamhenson!

seems like this might be replacing the "Foo" entry in this list? :)

readme.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview December 29, 2019 05:49 Inactive
@adamhenson
Copy link
Contributor Author

Right you are @patrickhulce! Thanks for your review. I removed the bullet for Foo and took you up on the suggestion of phrasing change.

@vercel vercel bot temporarily deployed to Preview December 29, 2019 20:47 Inactive
@adamhenson
Copy link
Contributor Author

@patrickhulce - I updated the copy further after using your edits. I think it's important to include some of the extra features people might be looking for as they glance through the bullets. I think the blurb is fairly trimmed and inline with others, but let me know if you have anything else you'd like to see updated. I appreciate this project, and all your work on it among the other contributors 👏

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep agreed @adamhenson this looks great to me! nice work!

@patrickhulce patrickhulce merged commit 4a52092 into GoogleChrome:master Dec 30, 2019
@adamhenson
Copy link
Contributor Author

Awesome thanks @patrickhulce!

@adamhenson adamhenson deleted the docs/automated-lighthouse-check.com branch December 30, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants