Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: add channel to runtime settings #10099

Merged
merged 4 commits into from
Jan 28, 2020
Merged

report: add channel to runtime settings #10099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0810a58
report: add channel to runtime settings
paulirish Dec 12, 2019
c036273
Update lighthouse-core/report/html/renderer/report-renderer.js
paulirish Jan 27, 2020
d72281e
Merge branch 'master' into reportchannel
paulirish Jan 27, 2020
04b6a9a
proto and sampljson
paulirish Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lighthouse-core/lib/i18n/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1598,6 +1598,9 @@
"lighthouse-core/report/html/renderer/util.js | runtimeSettingsBenchmark": {
"message": "CPU/Memory Power"
},
"lighthouse-core/report/html/renderer/util.js | runtimeSettingsChannel": {
"message": "Channel"
},
"lighthouse-core/report/html/renderer/util.js | runtimeSettingsCPUThrottling": {
"message": "CPU throttling"
},
Expand Down
3 changes: 3 additions & 0 deletions lighthouse-core/lib/i18n/locales/en-XL.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1598,6 +1598,9 @@
"lighthouse-core/report/html/renderer/util.js | runtimeSettingsBenchmark": {
"message": "ĈṔÛ/Ḿêḿôŕŷ Ṕôẃêŕ"
},
"lighthouse-core/report/html/renderer/util.js | runtimeSettingsChannel": {
"message": "Ĉh́âńn̂él̂"
},
"lighthouse-core/report/html/renderer/util.js | runtimeSettingsCPUThrottling": {
"message": "ĈṔÛ t́ĥŕôt́t̂ĺîńĝ"
},
Expand Down
1 change: 1 addition & 0 deletions lighthouse-core/report/html/renderer/report-renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ class ReportRenderer {
{name: Util.i18n.strings.runtimeSettingsFetchTime,
description: Util.i18n.formatDateTime(report.fetchTime)},
...envValues,
{name: Util.i18n.strings.runtimeSettingsChannel, description: report.configSettings.channel},
{name: Util.i18n.strings.runtimeSettingsUA, description: report.userAgent},
{name: Util.i18n.strings.runtimeSettingsUANetwork, description: report.environment &&
report.environment.networkUserAgent},
Expand Down
2 changes: 2 additions & 0 deletions lighthouse-core/report/html/renderer/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,8 @@ Util.UIStrings = {
runtimeSettingsNetworkThrottling: 'Network throttling',
/** Label for a row in a table that describes the CPU throttling conditions that were used during a Lighthouse run, if any.*/
runtimeSettingsCPUThrottling: 'CPU throttling',
/** Label for a row in a table that shows in what tool Lighthouse is being run (e.g. The lighthouse CLI, Chrome DevTools, Lightrider, WebPageTest, etc). */
runtimeSettingsChannel: 'Channel',
/** Label for a row in a table that shows the User Agent that was detected on the Host machine that ran Lighthouse. */
runtimeSettingsUA: 'User agent (host)',
/** Label for a row in a table that shows the User Agent that was used to send out all network requests during the Lighthouse run. */
Expand Down
1 change: 1 addition & 0 deletions lighthouse-core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5385,6 +5385,7 @@
"runtimeMobileEmulation": "Emulated Moto G4",
"runtimeNoEmulation": "No emulation",
"runtimeSettingsBenchmark": "CPU/Memory Power",
"runtimeSettingsChannel": "Channel",
"runtimeSettingsCPUThrottling": "CPU throttling",
"runtimeSettingsDevice": "Device",
"runtimeSettingsFetchTime": "Fetch Time",
Expand Down
3 changes: 3 additions & 0 deletions proto/lighthouse-result.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,9 @@ message I18n {

// Descriptive explanation for environment throttling that was provided by the runtime environment instead of provided by Lighthouse throttling.
string throttling_provided = 43;

// Label for a row in a table that shows in what tool Lighthouse is being run (e.g. The lighthouse CLI, Chrome DevTools, Lightrider, WebPageTest, etc).
string runtime_settings_channel = 44;
}

// The message holding all formatted strings
Expand Down
1 change: 1 addition & 0 deletions proto/sample_v2_round_trip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4188,6 +4188,7 @@
"runtimeNoEmulation": "No emulation",
"runtimeSettingsBenchmark": "CPU/Memory Power",
"runtimeSettingsCPUThrottling": "CPU throttling",
"runtimeSettingsChannel": "Channel",
"runtimeSettingsDevice": "Device",
"runtimeSettingsFetchTime": "Fetch Time",
"runtimeSettingsNetworkThrottling": "Network throttling",
Expand Down