Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(max-potential-first-input-delay): shorten description #10019

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Conversation

connorjclark
Copy link
Collaborator

this is a nit.

MPFID has the longest description and is the only one to make mention of the unit the metric presented in - which is understandable, since all the other are seconds and this is the outlier. But I don't think it's necessary, given that we display the units with the measure.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂ wfm

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. this has bugged me, too.

@paulirish paulirish merged commit 5e0cd06 into master Dec 11, 2019
@paulirish paulirish deleted the mfpid branch December 11, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants