Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper scripts not found when installed through npm #6150

Closed
r0mflip opened this issue Oct 1, 2018 · 2 comments
Closed

Helper scripts not found when installed through npm #6150

r0mflip opened this issue Oct 1, 2018 · 2 comments

Comments

@r0mflip
Copy link
Contributor

r0mflip commented Oct 1, 2018

Provide the steps to reproduce

$ npm i -g lighthouse
$ npm explore -g lighthouse -- ./lighthouse-core/scripts/download-chrome.sh

Result:

/bin/bash: ./lighthouse-core/scripts/download-chrome.sh: No such file or directory
npm ERR! file /bin/bash
npm ERR! code ENOENT
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! enoent spawn ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 
npm ERR! enoent Check if the file '/bin/bash' is present.

What is the current behavior?

Scripts like download-chrome.sh cannot be found in the scripts directory. I've also downloaded the tar file from https://registry.npmjs.org/lighthouse/-/lighthouse-3.2.1.tgz and can't find any scripts inside it.

What is the expected behavior?

I use this technique by @aerotwist in a similar way to test my site.

It worked fine for some time(ref: https://travis-ci.org/cbitosc/cbitosc.github.io/builds/433659287, uses lighthouse 3.1.1) but then started to fail (ref: https://travis-ci.org/cbitosc/cbitosc.github.io/builds/433965520 uses lighthouse 3.2.0).

Same behavior persists on my local machine too.

Environment Information

  • Affected Channels: CLI
  • Lighthouse version: 3.2.1
  • Node.js version: v10.11.0
  • Operating System: Ubuntu 18.04
@paulirish
Copy link
Member

Ah. This makes sense. we just changed out npmignore to exclude this script.

Yeah we can reintroduce this one. Thanks.

@r0mflip
Copy link
Contributor Author

r0mflip commented Oct 4, 2018

Thanks, closed in #6153

@r0mflip r0mflip closed this as completed Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants