feedback

GoogleChrome · May 6, 2018 · fc9a3cb · fc9a3cb
1 parent da6d230
commit fc9a3cb
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 195 deletions.
diff --git a/lighthouse-core/audits/audit.js b/lighthouse-core/audits/audit.js
@@ -186,10 +186,10 @@ class Audit {
       score,
       rawValue: result.rawValue,
 
-      displayValue: result.displayValue || '',
+      displayValue: result.displayValue,
       explanation: result.explanation,
       errorMessage: result.errorMessage,
-      warnings: result.warnings || [],
+      warnings: result.warnings,
 
       extendedInfo: result.extendedInfo,
       scoreDisplayMode,

diff --git a/lighthouse-core/report/html/renderer/report-renderer.js b/lighthouse-core/report/html/renderer/report-renderer.js
@@ -209,7 +209,7 @@ if (typeof module !== 'undefined' && module.exports) {
  *     description: string,
  *     explanation: (string|undefined),
  *     errorMessage: (string|undefined),
- *     displayValue: (string|Array<string|number>),
+ *     displayValue: (string|Array<string|number>|undefined),
  *     helpText: string,
  *     scoreDisplayMode: string,
  *     extendedInfo: Object,

diff --git a/lighthouse-core/runner.js b/lighthouse-core/runner.js
@@ -114,7 +114,7 @@ class Runner {
       for (const audit of auditResults) {
         resultsById[audit.name] = audit;
 
-        if (audit.warnings.length) {
+        if (audit.warnings && audit.warnings.length) {
           const prefixedWarnings = audit.warnings.map(msg => `${audit.description}: ${msg}`);
           lighthouseRunWarnings.push(...prefixedWarnings);
         }