core(external-anchors-use-rel-noopener): remove audit (#13298)

GoogleChrome · Nov 2, 2021 · fad498a · fad498a
1 parent bf2c15d
commit fad498a
Show file tree

Hide file tree

Showing 58 changed files with 7 additions and 1,097 deletions.
diff --git a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
@@ -396,9 +396,6 @@ Object {
     Object {
       "path": "dobetterweb/dom-size",
     },
-    Object {
-      "path": "dobetterweb/external-anchors-use-rel-noopener",
-    },
     Object {
       "path": "dobetterweb/geolocation-on-start",
     },
@@ -742,11 +739,6 @@ Object {
           "id": "is-on-https",
           "weight": 1,
         },
-        Object {
-          "group": "best-practices-trust-safety",
-          "id": "external-anchors-use-rel-noopener",
-          "weight": 1,
-        },
         Object {
           "group": "best-practices-trust-safety",
           "id": "geolocation-on-start",

diff --git a/lighthouse-cli/test/smokehouse/test-definitions/dobetterweb/dbw-expectations.js b/lighthouse-cli/test/smokehouse/test-definitions/dobetterweb/dbw-expectations.js
@@ -237,15 +237,6 @@ const expectations = {
           ],
         },
       },
-      'external-anchors-use-rel-noopener': {
-        score: 0,
-        warnings: [/Unable to determine.*<a target="_blank">/],
-        details: {
-          items: {
-            length: 3,
-          },
-        },
-      },
       'geolocation-on-start': {
         score: 0,
       },

diff --git a/lighthouse-cli/test/smokehouse/test-definitions/offline-local/offline-expectations.js b/lighthouse-cli/test/smokehouse/test-definitions/offline-local/offline-expectations.js
@@ -17,9 +17,6 @@ const onlineOnly = {
       'is-on-https': {
         score: 1,
       },
-      'external-anchors-use-rel-noopener': {
-        score: 1,
-      },
       'geolocation-on-start': {
         score: 1,
       },

diff --git a/lighthouse-core/audits/dobetterweb/external-anchors-use-rel-noopener.js b/lighthouse-core/audits/dobetterweb/external-anchors-use-rel-noopener.js
diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js
@@ -303,7 +303,6 @@ const defaultConfig = {
     'dobetterweb/doctype',
     'dobetterweb/charset',
     'dobetterweb/dom-size',
-    'dobetterweb/external-anchors-use-rel-noopener',
     'dobetterweb/geolocation-on-start',
     'dobetterweb/inspector-issues',
     'dobetterweb/no-document-write',
@@ -554,7 +553,6 @@ const defaultConfig = {
       auditRefs: [
         // Trust & Safety
         {id: 'is-on-https', weight: 1, group: 'best-practices-trust-safety'},
-        {id: 'external-anchors-use-rel-noopener', weight: 1, group: 'best-practices-trust-safety'},
         {id: 'geolocation-on-start', weight: 1, group: 'best-practices-trust-safety'},
         {id: 'notification-on-start', weight: 1, group: 'best-practices-trust-safety'},
         {id: 'no-vulnerable-libraries', weight: 1, group: 'best-practices-trust-safety'},

diff --git a/lighthouse-core/test/audits/dobetterweb/external-anchors-use-rel-noopener-test.js b/lighthouse-core/test/audits/dobetterweb/external-anchors-use-rel-noopener-test.js
diff --git a/lighthouse-core/test/fraggle-rock/scenarios/api-test-pptr.js b/lighthouse-core/test/fraggle-rock/scenarios/api-test-pptr.js
@@ -47,7 +47,7 @@ describe('Fraggle Rock API', () => {
 
       const {auditResults, erroredAudits, failedAudits} = getAuditsBreakdown(lhr);
       // TODO(FR-COMPAT): This assertion can be removed when full compatibility is reached.
-      expect(auditResults.length).toMatchInlineSnapshot(`75`);
+      expect(auditResults.length).toMatchInlineSnapshot(`74`);
 
       expect(erroredAudits).toHaveLength(0);
       expect(failedAudits.map(audit => audit.id)).toContain('label');
@@ -147,7 +147,7 @@ describe('Fraggle Rock API', () => {
       const {lhr} = result;
       const {auditResults, failedAudits, erroredAudits} = getAuditsBreakdown(lhr);
       // TODO(FR-COMPAT): This assertion can be removed when full compatibility is reached.
-      expect(auditResults.length).toMatchInlineSnapshot(`153`);
+      expect(auditResults.length).toMatchInlineSnapshot(`152`);
       expect(erroredAudits).toHaveLength(0);
 
       const failedAuditIds = failedAudits.map(audit => audit.id);