-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
new_audit(anchor-href): adds anchor-href audit
- Loading branch information
Showing
7 changed files
with
225 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| /** | ||
| * @license Copyright 2020 The Lighthouse Authors. All Rights Reserved. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. | ||
| */ | ||
| 'use strict'; | ||
|
|
||
| const Audit = require('../audit.js'); | ||
| const i18n = require('../../lib/i18n/i18n.js'); | ||
|
|
||
| const UIStrings = { | ||
| /** Title of a Lighthouse audit that provides detail on whether anchors have hyperlinks which can be crawled by search engines. This descriptive title is shown when all hyperlinks on the page are crawlable. */ | ||
| title: 'Anchors have crawlable hyperlinks', | ||
| /** Descriptive title of a Lighthouse audit that provides detail on whether anchors have hyperlinks which can be crawled by search engines. This descriptive title is shown when there are hyperlinks which are not crawlable by search engines. */ | ||
| failureTitle: 'Anchors do not have crawlable hyperlinks', | ||
| /** Description of a Lighthouse audit that tells the user why hyperlinks should be crawlable. This is displayed after a user expands the section to see more. 'Learn More' becomes link text to additional documentation. */ | ||
| description: 'Search engines use hyperlinks to crawl websites', | ||
| /** Label for a column in a data table; entries will be the HTML anchor elements that failed the audit. Anchors are DOM elements that are links. */ | ||
| columnFailingAnchors: 'Failing Anchor Elements', | ||
| }; | ||
|
|
||
| const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings); | ||
|
|
||
| class AnchorHref extends Audit { | ||
| /** | ||
| * @return {LH.Audit.Meta} | ||
| */ | ||
| static get meta() { | ||
| return { | ||
| id: 'anchor-href', | ||
| title: str_(UIStrings.title), | ||
| failureTitle: str_(UIStrings.failureTitle), | ||
| description: str_(UIStrings.description), | ||
| requiredArtifacts: ['AnchorElements'], | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * @param {LH.Artifacts} artifacts | ||
| * @return {LH.Audit.Product} | ||
| */ | ||
| static audit({AnchorElements: anchorElements}) { | ||
| const failingAnchorHrefs = anchorElements.filter(({rawHref}) => { | ||
| if (!rawHref) { | ||
| return true; | ||
| } | ||
|
|
||
| if (rawHref === '#') { | ||
| return true; | ||
| } | ||
|
|
||
| if (rawHref.startsWith('javascript:')) { | ||
| return true; | ||
| } | ||
|
|
||
| if (rawHref.startsWith('file:')) { | ||
| return true; | ||
| } | ||
| }); | ||
|
|
||
| /** @type {LH.Audit.Details.Table['headings']} */ | ||
| const headings = [{ | ||
| key: 'node', | ||
| itemType: 'node', | ||
| text: str_(UIStrings.columnFailingAnchors), | ||
| }]; | ||
|
|
||
| /** @type {LH.Audit.Details.Table['items']} */ | ||
| const itemsToDisplay = failingAnchorHrefs.map(node => { | ||
| return { | ||
| node: { | ||
| type: 'node', | ||
| snippet: node.outerHTML + node.text, | ||
| }, | ||
| }; | ||
| }); | ||
|
|
||
| return { | ||
| score: Number(failingAnchorHrefs.length === 0), | ||
| details: Audit.makeTableDetails(headings, itemsToDisplay), | ||
| }; | ||
| } | ||
| } | ||
|
|
||
| module.exports = AnchorHref; | ||
| module.exports.UIStrings = UIStrings; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /** | ||
| * @license Copyright 2020 The Lighthouse Authors. All Rights Reserved. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. | ||
| */ | ||
| 'use strict'; | ||
|
|
||
| const AnchorHrefAudit = require('../../../audits/seo/anchor-href.js'); | ||
| const assert = require('assert'); | ||
|
|
||
| /* eslint-env jest */ | ||
|
|
||
| function runAudit(rawHref) { | ||
| const {score} = AnchorHrefAudit.audit({ | ||
| AnchorElements: [{ | ||
| rawHref, | ||
| }], | ||
| }); | ||
|
|
||
| return score; | ||
| } | ||
|
|
||
| describe('SEO: Anchor Href audit', () => { | ||
| it('allows crawlable hrefs', () => { | ||
| assert.equal(runAudit('#top'), 1, 'hash fragment identifier'); | ||
| assert.equal(runAudit('mailto:[email protected]'), 1, 'email link with a mailto URI'); | ||
| assert.equal(runAudit('https://example.com'), 1, 'absolute HTTPs URL'); | ||
| assert.equal(runAudit('foo'), 1, 'relative URL'); | ||
| assert.equal(runAudit('/foo'), 1, 'relative URL'); | ||
| assert.equal(runAudit('#:~:text=string'), 1, 'hyperlink with a text fragment'); | ||
| assert.equal(runAudit('ftp://[email protected]'), 1, 'an FTP hyperlink'); | ||
| assert.equal(runAudit('http://172.217.20.78'), 1, 'IP address based link'); | ||
| assert.equal(runAudit('//example.com'), 1, 'protocol relative link'); | ||
| assert.equal(runAudit('?query=string'), 1, 'relative link which specifies a query string'); | ||
| assert.equal(runAudit('tel:5555555'), 1, 'email link with a tel URI'); | ||
| }); | ||
|
|
||
| it('disallows uncrawlable hrefs', () => { | ||
| assert.equal(runAudit(''), 0, 'link empty quotes for the href attribute'); | ||
| assert.equal(runAudit('#'), 0, 'link with only a hash symbol'); | ||
| assert.equal(runAudit('javascript:void(0)'), 0, 'hyperlink with a javascript URI'); | ||
| assert.equal(runAudit('file:///image.png'), 0, 'hyperlink with a javascript URI'); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters