don't mess with auditMode right now.

GoogleChrome · Oct 26, 2018 · e4817a8 · e4817a8
1 parent 9ccee72
commit e4817a8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lighthouse-core/lib/proto-preprocessor.js b/lighthouse-core/lib/proto-preprocessor.js
@@ -30,9 +30,6 @@ function processForProto(result) {
         reportJson.configSettings.output = [reportJson.configSettings.output];
       }
     }
-
-    // Remove until we resolve its string|boolean state
-    delete reportJson.configSettings.auditMode;
   }
 
   // Remove runtimeError if it is NO_ERROR

diff --git a/lighthouse-core/scripts/cleanup-LHR-for-diff.js b/lighthouse-core/scripts/cleanup-LHR-for-diff.js
@@ -26,6 +26,11 @@ function cleanAndFormatLHR(lhrString) {
   /** @type {LH.Result} */
   const lhr = JSON.parse(lhrString);
 
+  // TODO: Include this, but resolve
+  // 1) the string|boolean story for proto
+  // 2)  Travis gets a absolute path during yarn diff:sample-json
+  delete lhr.configSettings.auditMode;
+
   // Set timing values, which change from run to run, to predicable values
   lhr.timing.total = 12345.6789;
   lhr.timing.entries.forEach(entry => {

diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json
@@ -2736,7 +2736,6 @@
       "uploadThroughputKbps": 675,
       "cpuSlowdownMultiplier": 4
     },
-    "auditMode": "./lighthouse-core/test/results/artifacts",
     "gatherMode": false,
     "disableStorageReset": false,
     "disableDeviceEmulation": false,