core(network-request): add rendererStartTime (#14711)

GoogleChrome · Jan 26, 2023 · c14aaee · c14aaee
1 parent 955586c
commit c14aaee
Show file tree

Hide file tree

Showing 7 changed files with 294 additions and 193 deletions.
diff --git a/core/audits/network-requests.js b/core/audits/network-requests.js
@@ -31,8 +31,8 @@ class NetworkRequests extends Audit {
   static async audit(artifacts, context) {
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
     const records = await NetworkRecords.request(devtoolsLog, context);
-    const earliestStartTime = records.reduce(
-      (min, record) => Math.min(min, record.startTime),
+    const earliestRendererStartTime = records.reduce(
+      (min, record) => Math.min(min, record.rendererStartTime),
       Infinity
     );
 
@@ -47,8 +47,8 @@ class NetworkRequests extends Audit {
     }
 
     /** @param {number} time */
-    const normalizeTime = time => time < earliestStartTime || !Number.isFinite(time) ?
-      undefined : (time - earliestStartTime);
+    const normalizeTime = time => time < earliestRendererStartTime || !Number.isFinite(time) ?
+      undefined : (time - earliestRendererStartTime);
 
     const results = records.map(record => {
       const endTimeDeltaMs = record.lrStatistics?.endTimeDeltaMs;
@@ -64,6 +64,7 @@ class NetworkRequests extends Audit {
       return {
         url: UrlUtils.elideDataURI(record.url),
         protocol: record.protocol,
+        rendererStartTime: normalizeTime(record.rendererStartTime),
         startTime: normalizeTime(record.startTime),
         endTime: normalizeTime(record.endTime),
         finished: record.finished,
@@ -111,8 +112,8 @@ class NetworkRequests extends Audit {
     const tableDetails = Audit.makeTableDetails(headings, results);
 
     // Include starting timestamp to allow syncing requests with navStart/metric timestamps.
-    const networkStartTimeTs = Number.isFinite(earliestStartTime) ?
-        earliestStartTime * 1000 : undefined;
+    const networkStartTimeTs = Number.isFinite(earliestRendererStartTime) ?
+        earliestRendererStartTime * 1000 : undefined;
     tableDetails.debugData = {
       type: 'debugdata',
       networkStartTimeTs,

diff --git a/core/lib/network-request.js b/core/lib/network-request.js
@@ -125,6 +125,8 @@ class NetworkRequest {
     this.parsedURL = /** @type {ParsedURL} */ ({scheme: ''});
     this.documentURL = '';
 
+    /** When the renderer process initially discovers a network request, in milliseconds. */
+    this.rendererStartTime = -1;
     /**
      * When the network service is about to handle a request, ie. just before going to the
      * HTTP cache or going to the network for DNS/connection setup, in milliseconds.
@@ -222,6 +224,7 @@ class NetworkRequest {
     };
     this.isSecure = UrlUtils.isSecureScheme(this.parsedURL.scheme);
 
+    this.rendererStartTime = data.timestamp * 1000;
     // Expected to be overriden with better value in `_recomputeTimesWithResourceTiming`.
     this.startTime = data.timestamp * 1000;
 

diff --git a/core/test/audits/network-requests-test.js b/core/test/audits/network-requests-test.js
@@ -27,8 +27,9 @@ describe('Network requests audit', () => {
     const output = await NetworkRequests.audit(artifacts, {computedCache: new Map()});
 
     expect(output.details.items[0]).toMatchObject({
-      startTime: 0,
-      endTime: expect.toBeApproximately(701, 0),
+      rendererStartTime: 0,
+      startTime: expect.toBeApproximately(1, 0),
+      endTime: expect.toBeApproximately(702, 0),
       finished: true,
       transferSize: 11358,
       resourceSize: 39471,
@@ -38,7 +39,8 @@ describe('Network requests audit', () => {
       priority: 'VeryHigh',
     });
     expect(output.details.items[2]).toMatchObject({
-      startTime: expect.toBeApproximately(711, 0),
+      rendererStartTime: expect.toBeApproximately(710, 0),
+      startTime: expect.toBeApproximately(712, 0),
       endTime: expect.toBeApproximately(1289, 0),
       finished: false,
       transferSize: 26441,
@@ -49,8 +51,9 @@ describe('Network requests audit', () => {
       priority: 'Low',
     });
     expect(output.details.items[5]).toMatchObject({
+      rendererStartTime: expect.toBeApproximately(713, 0),
       startTime: expect.toBeApproximately(717, 0),
-      endTime: expect.toBeApproximately(1296, 0),
+      endTime: expect.toBeApproximately(1297, 0),
       finished: false,
       transferSize: 58571,
       resourceSize: 0,
@@ -62,7 +65,7 @@ describe('Network requests audit', () => {
 
     expect(output.details.debugData).toStrictEqual({
       type: 'debugdata',
-      networkStartTimeTs: 360725781425,
+      networkStartTimeTs: 360725780729,
     });
   });