core(target-size): use binary display mode (#15910)

GoogleChrome · Apr 3, 2024 · 734dffa · 734dffa
1 parent 458ded8
commit 734dffa
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 17 deletions.
diff --git a/cli/test/smokehouse/test-definitions/a11y.js b/cli/test/smokehouse/test-definitions/a11y.js
@@ -900,7 +900,7 @@ const expectations = {
         },
       },
       'target-size': {
-        score: 1,
+        score: 0,
         details: {
           items: [
             {

diff --git a/core/audits/accessibility/target-size.js b/core/audits/accessibility/target-size.js
@@ -35,7 +35,6 @@ class TargetSize extends AxeAudit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
-      scoreDisplayMode: AxeAudit.SCORING_MODES.INFORMATIVE,
       requiredArtifacts: ['Accessibility'],
     };
   }

diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json
@@ -2701,8 +2701,13 @@
             "id": "target-size",
             "title": "Touch targets have sufficient size and spacing.",
             "description": "Touch targets with sufficient size and spacing help users who may have difficulty targeting small controls to activate the targets. [Learn more about touch targets](https://dequeuniversity.com/rules/axe/4.9/target-size).",
-            "score": null,
-            "scoreDisplayMode": "notApplicable"
+            "score": 1,
+            "scoreDisplayMode": "binary",
+            "details": {
+              "type": "table",
+              "headings": [],
+              "items": []
+            }
           },
           "td-has-header": {
             "id": "td-has-header",
@@ -4365,7 +4370,7 @@
               },
               {
                 "id": "target-size",
-                "weight": 0,
+                "weight": 7,
                 "group": "a11y-best-practices"
               },
               {
@@ -14467,8 +14472,13 @@
             "id": "target-size",
             "title": "Touch targets have sufficient size and spacing.",
             "description": "Touch targets with sufficient size and spacing help users who may have difficulty targeting small controls to activate the targets. [Learn more about touch targets](https://dequeuniversity.com/rules/axe/4.9/target-size).",
-            "score": null,
-            "scoreDisplayMode": "notApplicable"
+            "score": 1,
+            "scoreDisplayMode": "binary",
+            "details": {
+              "type": "table",
+              "headings": [],
+              "items": []
+            }
           },
           "td-has-header": {
             "id": "td-has-header",
@@ -15253,7 +15263,7 @@
               },
               {
                 "id": "target-size",
-                "weight": 0,
+                "weight": 7,
                 "group": "a11y-best-practices"
               },
               {
@@ -20347,8 +20357,13 @@
             "id": "target-size",
             "title": "Touch targets have sufficient size and spacing.",
             "description": "Touch targets with sufficient size and spacing help users who may have difficulty targeting small controls to activate the targets. [Learn more about touch targets](https://dequeuniversity.com/rules/axe/4.9/target-size).",
-            "score": null,
-            "scoreDisplayMode": "notApplicable"
+            "score": 1,
+            "scoreDisplayMode": "binary",
+            "details": {
+              "type": "table",
+              "headings": [],
+              "items": []
+            }
           },
           "td-has-header": {
             "id": "td-has-header",
@@ -22081,7 +22096,7 @@
               },
               {
                 "id": "target-size",
-                "weight": 0,
+                "weight": 7,
                 "group": "a11y-best-practices"
               },
               {

diff --git a/core/test/results/sample_v2.json b/core/test/results/sample_v2.json
@@ -4037,8 +4037,13 @@
       "id": "target-size",
       "title": "Touch targets have sufficient size and spacing.",
       "description": "Touch targets with sufficient size and spacing help users who may have difficulty targeting small controls to activate the targets. [Learn more about touch targets](https://dequeuniversity.com/rules/axe/4.9/target-size).",
-      "score": null,
-      "scoreDisplayMode": "notApplicable"
+      "score": 1,
+      "scoreDisplayMode": "binary",
+      "details": {
+        "type": "table",
+        "headings": [],
+        "items": []
+      }
     },
     "td-has-header": {
       "id": "td-has-header",
@@ -6452,7 +6457,7 @@
         },
         {
           "id": "target-size",
-          "weight": 0,
+          "weight": 7,
           "group": "a11y-best-practices"
         },
         {
@@ -6547,7 +6552,7 @@
         }
       ],
       "id": "accessibility",
-      "score": 0.77
+      "score": 0.78
     },
     "best-practices": {
       "title": "Best Practices",

diff --git a/report/test/generator/report-generator-test.js b/report/test/generator/report-generator-test.js
@@ -107,7 +107,7 @@ describe('ReportGenerator', () => {
 
 category,score
 \\"performance\\",\\"0.28\\"
-\\"accessibility\\",\\"0.77\\"
+\\"accessibility\\",\\"0.78\\"
 \\"best-practices\\",\\"0.35\\"
 \\"seo\\",\\"0.73\\"
 \\"pwa\\",\\"0.38\\"

diff --git a/report/test/renderer/category-renderer-test.js b/report/test/renderer/category-renderer-test.js
@@ -304,7 +304,7 @@ describe('CategoryRenderer', () => {
       );
 
       const gauge = categoryDOM.querySelector('.lh-fraction__content');
-      assert.equal(gauge.textContent.trim(), '19/24', 'fraction is included');
+      assert.equal(gauge.textContent.trim(), '20/25', 'fraction is included');
 
       const score = categoryDOM.querySelector('.lh-category-header');
       const title = score.querySelector('.lh-fraction__label');

diff --git a/third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts b/third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts
@@ -80,6 +80,7 @@ describe('Snapshot', function() {
       'document-title',
       'html-has-lang',
       'label',
+      'target-size',
       'meta-description',
     ]);