maybe

GoogleChrome · Nov 5, 2021 · 6c2e95c · 6c2e95c
1 parent ee89953
commit 6c2e95c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lighthouse-core/audits/byte-efficiency/byte-efficiency-audit.js b/lighthouse-core/audits/byte-efficiency/byte-efficiency-audit.js
@@ -206,7 +206,6 @@ class UnusedBytes extends Audit {
    */
   static computeWastedMsWithThroughput(wastedBytes, simulator) {
     const bitsPerSecond = simulator.getOptions().throughput;
-    if (bitsPerSecond === 0) return 0;
     const wastedBits = wastedBytes * 8;
     const wastedMs = wastedBits / bitsPerSecond * 1000;
     return wastedMs;

diff --git a/lighthouse-core/computed/load-simulator.js b/lighthouse-core/computed/load-simulator.js
@@ -63,9 +63,14 @@ class LoadSimulator {
         break;
       default:
         // intentionally fallback to simulator defaults
-        break;
+        return new Simulator(options);
     }
 
+    // 0 should be interpreted as "unset" for these values.
+    // Fallback to environment values in this case.
+    if (options.rtt === 0) options.rtt = networkAnalysis.rtt;
+    if (options.throughput === 0) options.throughput = networkAnalysis.throughput;
+
     return new Simulator(options);
   }