misc: address release script feedback (#9111)

docs/releasing.md

@@ -44,24 +44,26 @@ bash ./lighthouse-core/scripts/release/test.sh
 # Package everything for publishing
 bash ./lighthouse-core/scripts/release/prepare-package.sh
 
+# Make sure you're in the Lighthouse pristine repo we just tested.
+cd ../lighthouse-pristine
+
+# Publish to NPM
+npm publish
+
+# Publish viewer
+yarn deploy-viewer
+
 # Upload the extension
-node build/build-extension.js package; cd dist/extension-package/
 open https://chrome.google.com/webstore/developer/edit/blipmdconlkpinefehnmjammfjpmpbjk
-echo "Upload the package zip to CWS dev dashboard"
+cd dist/extension-package/
+echo "Upload the package zip to CWS dev dashboard..."
 # Be in lighthouse-extension-owners group
 # Open <https://chrome.google.com/webstore/developer/dashboard>
 # Click _Edit_ on lighthouse
 # _Upload Updated Package_
-# Select `lighthouse-4.X.X.zip`
+# Select `lighthouse-X.X.X.zip`
 # _Publish_ at the bottom
 
-# Make sure you're in the Lighthouse pristine repo we just tested.
-cd ../lighthouse-pristine
-# Publish to NPM
-npm publish
-# Publish viewer
-yarn deploy-viewer
-
 # * Tell the world!!! *
 echo "Complete the _Release publicity_ tasks documented above"
 ```

lighthouse-core/scripts/release/prepare-commit.sh

@@ -70,7 +70,7 @@ echo "Version bump commit ready on the ${TXT_BOLD}$BRANCH_NAME${TXT_RESET} branc
 
 echo "${TXT_DIM}Press any key to see the git diff, CTRL+C to exit...${TXT_RESET}"
 read -n 1 -r unused_variable
-git --no-pager diff HEAD^
+git diff HEAD^
 echo "${TXT_DIM}Press any key to push to GitHub, CTRL+C to exit...${TXT_RESET}"
 read -n 1 -r unused_variable
 git push -u origin "$BRANCH_NAME"

lighthouse-core/scripts/release/test.sh

@@ -24,7 +24,7 @@ echo "Running the standard test suite..."
 yarn test
 
 echo "Running the smoke tests...."
-yarn smoke
+yarn smoke || yarn smoke || yarn smoke
 
 echo "Testing the CLI..."
 yarn start "https://example.com" --view