Skip to content

Commit

Permalink
core(viewport): support interactive-widget (#14664)
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark authored Jan 23, 2023
1 parent 421844c commit 3686757
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
6 changes: 6 additions & 0 deletions core/test/computed/viewport-meta-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ describe('ViewportMeta computed artifact', () => {
}));
});

it('recognizes interactive-widget property', async () => {
const viewport = 'width=device-width, interactive-widget=resizes-content';
const {parserWarnings} = await ViewportMeta.compute_(makeMetaElements(viewport));
assert.equal(parserWarnings[0], undefined);
});

it('doesn\'t throw when viewport contains "invalid" iOS properties', async () => {
const viewports = [
'width=device-width, shrink-to-fit=no',
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
"lighthouse-stack-packs": "1.8.2",
"lodash": "^4.17.21",
"lookup-closest-locale": "6.2.0",
"metaviewport-parser": "0.2.0",
"metaviewport-parser": "0.3.0",
"open": "^8.4.0",
"parse-cache-control": "1.0.1",
"ps-list": "^8.0.0",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5246,10 +5246,10 @@ merge2@^1.2.3, merge2@^1.3.0, merge2@^1.4.1:
resolved "https://registry.yarnpkg.com/merge2/-/merge2-1.4.1.tgz#4368892f885e907455a6fd7dc55c0c9d404990ae"
integrity sha512-8q7VEgMJW4J8tcfVPy8g09NcQwZdbwFEqhe/WZkoIzjn/3TGDwtOCYtXGxA3O8tPzpczCCDgv+P2P5y00ZJOOg==

metaviewport-parser@0.2.0:
version "0.2.0"
resolved "https://registry.yarnpkg.com/metaviewport-parser/-/metaviewport-parser-0.2.0.tgz#535c3ce1ccf6223a5025fddc6a1c36505f7e7db1"
integrity sha1-U1w84cz2IjpQJf3cahw2UF9+fbE=
metaviewport-parser@0.3.0:
version "0.3.0"
resolved "https://registry.yarnpkg.com/metaviewport-parser/-/metaviewport-parser-0.3.0.tgz#6af1e99b5eaf250c049e0af1e84143a39750dea6"
integrity sha512-EoYJ8xfjQ6kpe9VbVHvZTZHiOl4HL1Z18CrZ+qahvLXT7ZO4YTC2JMyt5FaUp9JJp6J4Ybb/z7IsCXZt86/QkQ==

micromatch@^3.1.10:
version "3.1.10"
Expand Down

0 comments on commit 3686757

Please sign in to comment.