feedback.

GoogleChrome · Nov 21, 2017 · 15a56c4 · 15a56c4
1 parent 4a94927
commit 15a56c4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/lighthouse-core/gather/connections/connection.js b/lighthouse-core/gather/connections/connection.js
@@ -32,7 +32,7 @@ class Connection {
 
 
   /**
-   * @return {!Promise}
+   * @return {!Promise<string>}
    */
   wsEndpoint() {
     return Promise.reject(new Error('Not implemented'));

diff --git a/lighthouse-core/gather/connections/cri.js b/lighthouse-core/gather/connections/cri.js
@@ -143,7 +143,7 @@ class CriConnection extends Connection {
    * @return {!Promise<string>}
    */
   wsEndpoint() {
-    return this._runJsonCommand('version').then(response => response.webSocketDebuggerUrl)
+    return this._runJsonCommand('version').then(response => response.webSocketDebuggerUrl);
   }
 
 

diff --git a/lighthouse-core/gather/driver.js b/lighthouse-core/gather/driver.js
@@ -104,6 +104,11 @@ class Driver {
     return this._connection.disconnect();
   }
 
+  /**
+   * Get the browser WebSocket endpoint for devtools protocol clients like Puppeteer
+   * Only works with WebSocket connection, not extension or devtools
+   * @return {!Promise<string>}
+   */
   wsEndpoint() {
     return this._connection.wsEndpoint();
   }