Skip to content

Commit

Permalink
test fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
@brendankenny
brendankenny committed May 10, 2022
1 parent c256446 commit 084bbe4
Show file tree
Hide file tree
Showing 5 changed files with 196 additions and 136 deletions.
324 changes: 188 additions & 136 deletions lighthouse-core/test/audits/work-during-interaction-test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,18 @@ describe('Interaction to Next Paint', () => {
devtoolsLogs: {
[WorkDuringInteraction.DEFAULT_PASS]: [],
},
TraceElements: [{
traceEventType: 'responsiveness',
node: {
lhId: 'page-0-INPUT',
devtoolsNodePath: '1,HTML,1,BODY,1,INPUT',
selector: 'body > input#events-typey',
boundingRect: {top: 160, bottom: 181, left: 8, right: 592, width: 584, height: 22},
snippet: '<input type="text" placeholder="Typey" id="events-typey">',
nodeLabel: 'body > input#events-typey',
},
nodeId: 10,
}],
};

const context = {
Expand All @@ -36,154 +48,194 @@ describe('Interaction to Next Paint', () => {
expect(result).toMatchInlineSnapshot(`
Object {
"details": Object {
"debugData": Object {
"interactionType": "mousedown",
"phases": Object {
"inputDelay": Object {
"endTs": 633282608296,
"startTs": 633282566296,
},
"presentationDelay": Object {
"endTs": 633282934296,
"startTs": 633282649296,
},
"processingDelay": Object {
"endTs": 633282649296,
"startTs": 633282608296,
},
},
"type": "debugdata",
},
"headings": Array [
Object {
"itemType": "text",
"key": "phase",
"subItemsHeading": Object {
"itemType": "url",
"key": "url",
},
"text": "Phase",
},
Object {
"granularity": 1,
"itemType": "ms",
"key": "total",
"subItemsHeading": Object {
"granularity": 1,
"itemType": "ms",
"key": "total",
},
"text": "Total time",
},
Object {
"itemType": "ms",
"key": null,
"subItemsHeading": Object {
"granularity": 1,
"itemType": "ms",
"key": "scripting",
},
"text": "Script evaluation",
},
Object {
"itemType": "ms",
"key": null,
"subItemsHeading": Object {
"granularity": 1,
"itemType": "ms",
"key": "layout",
},
"text": "Style & Layout",
},
Object {
"itemType": "ms",
"key": null,
"subItemsHeading": Object {
"granularity": 1,
"itemType": "ms",
"key": "render",
},
"text": "Rendering",
},
],
"items": Array [
Object {
"phase": Object {
"formattedDefault": "Input delay",
"i18nId": "lighthouse-core/audits/work-during-interaction.js | inputDelay",
"values": undefined,
},
"subItems": Object {
"items": Array [
Object {
"layout": 0,
"render": 0,
"scripting": 39.855000019073486,
"total": 40.68599998950958,
"url": "http://localhost:10200/events.html",
"headings": Array [
Object {
"itemType": "node",
"key": "node",
"text": Object {
"formattedDefault": "Event target",
"i18nId": "lighthouse-core/audits/work-during-interaction.js | eventTarget",
"values": undefined,
},
Object {
"layout": 0,
"render": 0,
"scripting": 0,
"total": 1.3049999475479126,
"url": "Unattributable",
},
],
"items": Array [
Object {
"node": Object {
"boundingRect": Object {
"bottom": 181,
"height": 22,
"left": 8,
"right": 592,
"top": 160,
"width": 584,
},
"lhId": "page-0-INPUT",
"nodeLabel": "body > input#events-typey",
"path": "1,HTML,1,BODY,1,INPUT",
"selector": "body > input#events-typey",
"snippet": "<input type=\\"text\\" placeholder=\\"Typey\\" id=\\"events-typey\\">",
"type": "node",
},
],
"type": "subitems",
},
"total": 42,
},
],
"summary": undefined,
"type": "table",
},
Object {
"phase": Object {
"formattedDefault": "Processing delay",
"i18nId": "lighthouse-core/audits/work-during-interaction.js | processingDelay",
"values": undefined,
},
"subItems": Object {
"items": Array [
Object {
"layout": 0,
"render": 0,
"scripting": 40.6599999666214,
"total": 41,
"url": "http://localhost:10200/events.html",
"headings": Array [
Object {
"itemType": "text",
"key": "phase",
"subItemsHeading": Object {
"itemType": "url",
"key": "url",
},
],
"type": "subitems",
},
"total": 41,
},
Object {
"phase": Object {
"formattedDefault": "Presentation delay",
"i18nId": "lighthouse-core/audits/work-during-interaction.js | presentationDelay",
"values": undefined,
},
"subItems": Object {
"items": Array [
Object {
"layout": 0,
"render": 0,
"scripting": 272.8389996290207,
"total": 278.7499998807907,
"url": "http://localhost:10200/events.html",
"text": "Phase",
},
Object {
"granularity": 1,
"itemType": "ms",
"key": "total",
"subItemsHeading": Object {
"granularity": 1,
"itemType": "ms",
"key": "total",
},
Object {
"layout": 0,
"render": 0,
"scripting": 0.03100001811981201,
"total": 2.01800000667572,
"url": "Unattributable",
"text": "Total time",
},
Object {
"itemType": "ms",
"key": null,
"subItemsHeading": Object {
"granularity": 1,
"itemType": "ms",
"key": "scripting",
},
],
"type": "subitems",
"text": "Script evaluation",
},
Object {
"itemType": "ms",
"key": null,
"subItemsHeading": Object {
"granularity": 1,
"itemType": "ms",
"key": "layout",
},
"text": "Style & Layout",
},
Object {
"itemType": "ms",
"key": null,
"subItemsHeading": Object {
"granularity": 1,
"itemType": "ms",
"key": "render",
},
"text": "Rendering",
},
],
"items": Array [
Object {
"phase": Object {
"formattedDefault": "Input delay",
"i18nId": "lighthouse-core/audits/work-during-interaction.js | inputDelay",
"values": undefined,
},
"subItems": Object {
"items": Array [
Object {
"layout": 0,
"render": 0,
"scripting": 39.855000019073486,
"total": 40.68599998950958,
"url": "http://localhost:10200/events.html",
},
Object {
"layout": 0,
"render": 0,
"scripting": 0,
"total": 1.3049999475479126,
"url": "Unattributable",
},
],
"type": "subitems",
},
"total": 42,
},
Object {
"phase": Object {
"formattedDefault": "Processing delay",
"i18nId": "lighthouse-core/audits/work-during-interaction.js | processingDelay",
"values": undefined,
},
"subItems": Object {
"items": Array [
Object {
"layout": 0,
"render": 0,
"scripting": 40.6599999666214,
"total": 41,
"url": "http://localhost:10200/events.html",
},
],
"type": "subitems",
},
"total": 41,
},
Object {
"phase": Object {
"formattedDefault": "Presentation delay",
"i18nId": "lighthouse-core/audits/work-during-interaction.js | presentationDelay",
"values": undefined,
},
"subItems": Object {
"items": Array [
Object {
"layout": 0,
"render": 0,
"scripting": 272.8389996290207,
"total": 278.7499998807907,
"url": "http://localhost:10200/events.html",
},
Object {
"layout": 0,
"render": 0,
"scripting": 0.03100001811981201,
"total": 2.01800000667572,
"url": "Unattributable",
},
],
"type": "subitems",
},
"total": 285,
},
],
"summary": undefined,
"type": "table",
},
Object {
"interactionType": "mousedown",
"phases": Object {
"inputDelay": Object {
"endTs": 633282608296,
"startTs": 633282566296,
},
"presentationDelay": Object {
"endTs": 633282934296,
"startTs": 633282649296,
},
"processingDelay": Object {
"endTs": 633282649296,
"startTs": 633282608296,
},
},
"total": 285,
"type": "debugdata",
},
],
"summary": undefined,
"type": "table",
"type": "list",
},
"displayValue": Object {
"formattedDefault": "370 ms spent on event 'mousedown'",
Expand Down
3 changes: 3 additions & 0 deletions shared/localization/locales/en-US.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions shared/localization/locales/en-XL.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ...sts/webtests/http/tests/devtools/lighthouse/lighthouse-successful-navigation-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Computing artifact: MainResource$k
Collect stacks
Computing artifact: ProcessedTrace$h
Computing artifact: ProcessedNavigation$7
Computing artifact: Responsiveness
Get webapp manifest
Audit phase
Analyzing and running audits...
Expand Down
1 change: 1 addition & 0 deletions ...m-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ Gathering: Accessibility
Gathering: TraceElements
Computing artifact: ProcessedTrace$h
Computing artifact: ProcessedNavigation$7
Computing artifact: Responsiveness
Gathering: InspectorIssues
Gathering: SourceMaps
Gathering: FullPageScreenshot
Expand Down

0 comments on commit 084bbe4

Please sign in to comment.