collect: use new headless mode #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Apr 27, 2023
| @@ -78,7 +78,7 @@ describe('Lighthouse CI collect CLI with puppeteer', () => { | |||
| const files = fs.readdirSync(path.join(autorunDir, '.lighthouseci')); | |||
| const report = files.find(file => /lhr.*\.json$/.test(file)); | |||
| const lhr = JSON.parse(fs.readFileSync(path.join(autorunDir, '.lighthouseci', report))); | |||
| expect(lhr.userAgent).toContain('HeadlessChrome/111.0.5555.0'); // make sure the right chrome was used | |||
| expect(lhr.userAgent).toContain('Chrome/111.0.0.0'); // make sure the right chrome was used | |||
There was a problem hiding this comment.
Needed because --headless=new no longer announces itself in the UA string.
From #336 the condition being asserted seems to be that puppeteer's Chrome was used, not that it was headless in particular (that's just the default without headful: true in the options), so this change seems ok.
adamraine
approved these changes
Apr 27, 2023
gmerwan
approved these changes
Jul 25, 2023
|
Guys, any chance this Pull Request will be merged soon? |
connorjclark
force-pushed
the
headless-new
branch
from
122480d
to
75fba62
Compare
This was referenced Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to --headless=new when
headfulisn't requested.This is better in general, but should also fix bfcache results which have issues with the old headless mode (see treosh/lighthouse-ci-action#126, catchpoint/WebPageTest.agent#605).
I'd like to add a test that the bfcache audit isn't blocked by getting the "Back/forward cache is not supported by delegate" failure anymore, but I haven't found a good place to add that. Happy to take any suggestions!