Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): skip needless/verbose audit diffs #881

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

paulirish
Copy link
Member

A number of audits currently get full diff rendering but its nonsensical to diff them. (main-thread-tasks is an obvious one).
This introduces a blocklist for those audits.

It also dramatically improves the performance when viewing two lhrs that have lots of tasks.

@paulirish paulirish changed the title skip loud audit diffs report diff: skip needless/verbose audit diffs Mar 3, 2023
@paulirish
Copy link
Member Author

@connorjclark this one work for you too?

@connorjclark connorjclark changed the title report diff: skip needless/verbose audit diffs fix(server): skip needless/verbose audit diffs Mar 6, 2023
@connorjclark connorjclark merged commit b484e69 into main Mar 6, 2023
@connorjclark connorjclark deleted the skip-loud-audit-diffs-solo branch March 6, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants