feat: upgrade to lighthouse 9.3.0 #726
Conversation
BREAKING CHANGE: upgrade to lighthouse v9.0.0
|
WIP, tests aren't running / snapshots aren't updating as expected locally for me. |
|
FYI, lighthouse 9.1 was released so it would be nice if we could get this PR all the way to the latest version |
|
There is now even lighthouse v9.2.0, is there is anything blocking this PR? |
connorjclark
changed the title
|
seems the |
|
packages/cli/test/cli.test.js
Outdated
| @@ -409,15 +399,6 @@ describe('Lighthouse CI CLI', () => { | |||
| found: [31mXXXX[0m | |||
| [2mall values: XXXX, XXXX[0m | |||
|
|
|||
|
|
|||
| [31mX[0m [1mperformance-budget[0m.script.size failure for [1mmaxNumericValue[0m assertion | |||
There was a problem hiding this comment.
connorjclark
changed the title
| @@ -53,6 +57,7 @@ const auditPairs62 = createAuditPairs(lhr62A, lhr62B); | |||
| const auditPairs641 = createAuditPairs(lhr641A, lhr641B); | |||
| const auditPairs700 = createAuditPairs(lhr700A, lhr700B); | |||
| const auditPairs800 = createAuditPairs(lhr800A, lhr800B); | |||
| const auditPairs930 = createAuditPairs(lhr930A, lhr930B); | |||
There was a problem hiding this comment.
Not sure why the audit pairs for the other versions don't have this problem, but for the 9.3.0 LHR I'm getting a diff at screenshot-thumbnails, as you'd expect. But the viz is non existent so we just print the JSON.
Not sure what the best approach to deal with this is. Is it problematic that this audit is presented this way? How would we prevent it from ever being displayed? Should I just skip it in the createAuditPairs like uses-long-cache-ttl is skipped?
There was a problem hiding this comment.
confirmed this is existing behavior in https://googlechrome.github.io/lighthouse-ci/viewer/
include in commit message: