docs(recipes): Update Kubernetes deployment instructions #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pod by iteself is not resilient and will not be recreated if the node fails, for example.
patrickhulce
requested changes
Jan 8, 2021
There was a problem hiding this comment.
thanks very much @ddunkin! I'll be honest I don't know much about k8s, so your help is much appreciated but my review is not all that valuable :) seems good!
just the one script change
| spec: | ||
| containers: | ||
| - name: lhci-server | ||
| image: docker.io/patrickhulce/lhci-server:0.6.1 |
There was a problem hiding this comment.
can you update the line in the update-dockerhub.sh script that replaces this value? it's pointing to the now non-existent lhci-pod.yml
This was referenced Apr 13, 2021
This was referenced Sep 15, 2021
This was referenced Jan 19, 2022
This was referenced May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.