Update Docs on SQL Connection URL Format #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under the covers, it seems that the value of `sqlConnectionUrl` is passed through to Sequelize, so we should be more clear about what's allowed in the format of that string. Relevant Sequelize documentation on the proper format can be seen here: https://sequelize.org/v4/manual/installation/getting-started.html#setting-up-a-connection.
patrickhulce
approved these changes
Sep 22, 2020
denkrasnov
pushed a commit
to Travix-International/lighthouse-ci
that referenced
this pull request
Oct 29, 2020
This was referenced Dec 19, 2020
This was referenced Jan 28, 2021
This was referenced Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the covers, it seems that the value of
sqlConnectionUrlis passed through to Sequelize, so we should be more clear about what's allowed in the format of that string. Relevant Sequelize documentation on the proper format can be seen here: https://sequelize.org/v4/manual/installation/getting-started.html#setting-up-a-connection.