Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(recipes): Update Kubernetes deployment instructions #526

Merged
merged 3 commits into from
Jan 8, 2021

Conversation

ddunkin
Copy link
Contributor

@ddunkin ddunkin commented Jan 8, 2021

No description provided.

A pod by iteself is not resilient and will not be recreated if the node
fails, for example.
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much @ddunkin! I'll be honest I don't know much about k8s, so your help is much appreciated but my review is not all that valuable :) seems good!

just the one script change

spec:
containers:
- name: lhci-server
image: docker.io/patrickhulce/lhci-server:0.6.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the line in the update-dockerhub.sh script that replaces this value? it's pointing to the now non-existent lhci-pod.yml

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants