is getAncestorHash in healthcheck relevent as implemented yet ?

[jfmou]

I'm having little trouble understanding the point of this check which fails on my pipeline most of the time.
We do "merge with commit" our feature branches into develop then develop into master.
The base branch for our repo in our lhci server is develop.

When auditing our feature branches or freshly merged develop with lhci the check systematicaly fails since baseBranch isn't set, resulting in getAncestorHashForBranch using master as default branch which is not present as an ancestor of develop (nor the feature branches).

Uploads never failed that said, since the implementation seems more robust, requesting server data for baseBranch :

lighthouse-ci/packages/cli/src/upload/upload.js

Lines 399 to 409 in 0c5db08

	api.setBuildToken(options.token);
	const project = await api.findProjectByToken(options.token);
	if (!project) {
	throw new Error('Could not find active project with provided token');
	}
	const baseBranch = project.baseBranch || 'master';
	const hash = getCurrentHash();
	const branch = getCurrentBranch();
	const ancestorHash =
	branch === baseBranch ? getAncestorHashForBase() : getAncestorHashForBranch('HEAD', baseBranch);

It doesn't fail the job and is only a warning, but it triggers me on the check itself and what to expect about it, since it always assume master is an ancestor.
I guess It would never failed if we did used fast forward merge strategy right ? Making master and develop always an ancestor of the feature branch.

I may be missing something here, but when i audit our master it succeeds, making me think I have a good lead.
Any ideas ?

[patrickhulce]

Thanks for filing @jfmou! You're right we should be threading through the baseBranch into the getAncestorHash function instead of hardcoding master there :)

lighthouse-ci/packages/utils/src/build-context.js

Lines 319 to 329 in 0449e6e

	function getAncestorHash(hash = 'HEAD') {
	const envHash = getEnvVarIfSet([
	// Manual override
	'LHCI_BUILD_CONTEXT__ANCESTOR_HASH',
	]);
	if (envHash) return envHash;
	return getCurrentBranch() === 'master'
	? getAncestorHashForBase(hash)
	: getAncestorHashForBranch(hash);
	}

We'll need to make the same project API request to fetch the baseBranch

[jfmou]

Well glad to help ! Thanks for your feedback. Love this product 🥇