Don't mutate user settings

Fixes #1067 Closes #1022
GoogleChrome · Aug 3, 2024 · 5d94ceb · 5d94ceb
1 parent 2cb0d07
commit 5d94ceb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/cli/src/collect/node-runner.js b/packages/cli/src/collect/node-runner.js
@@ -42,7 +42,7 @@ class LighthouseRunner {
    * @return {{args: string[], cleanupFn: () => void}}
    */
   static computeArgumentsAndCleanup(url, options) {
-    const settings = options.settings || {};
+    const settings = {...options.settings};
     const chromeFlags = options.settings && options.settings.chromeFlags;
     let chromeFlagsAsString = chromeFlags || '';
     if (!options.headful) chromeFlagsAsString += ' --headless=new';