This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2831
Ran into this issue because I was running Node 18 locally and it's an easy fix. The only breaking change in
markdown-it-attrs
since 3.0.3 is that there must be a new line between a markdown table and an attribute block immediately after it (e.g. setting anid
on the generated table).However this is a change from
markdown-it@^12
, notmarkdown-it-attrs
, and d.c.c has been runningmarkdown-it@^12.0.1
for the last two years, so that requirement has already been in place this whole time. The only thing that's changed is that npm got stricter aboutpeerDependencies
versioning.I still made a search of all the markdown tables (there aren't many) and I found none that had an attribute block right afterwards. The only page with something similar was the mv2 content_scripts docs, which uses attribute blocks to set anchors inside markdown tables. Those seem to render just fine, and a diff of the generated page before and after shows no change, so I think it's good.