Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

deps: update markdown-it-attrs #2892

Merged
merged 1 commit into from
May 26, 2022
Merged

deps: update markdown-it-attrs #2892

merged 1 commit into from
May 26, 2022

Conversation

brendankenny
Copy link
Member

Fixes #2831

Ran into this issue because I was running Node 18 locally and it's an easy fix. The only breaking change in markdown-it-attrs since 3.0.3 is that there must be a new line between a markdown table and an attribute block immediately after it (e.g. setting an id on the generated table).

However this is a change from markdown-it@^12, not markdown-it-attrs, and d.c.c has been running markdown-it@^12.0.1 for the last two years, so that requirement has already been in place this whole time. The only thing that's changed is that npm got stricter about peerDependencies versioning.

I still made a search of all the markdown tables (there aren't many) and I found none that had an attribute block right afterwards. The only page with something similar was the mv2 content_scripts docs, which uses attribute blocks to set anchors inside markdown tables. Those seem to render just fine, and a diff of the generated page before and after shows no change, so I think it's good.

@brendankenny brendankenny requested a review from jeffposnick May 24, 2022 18:33
@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for developer-chrome-com ready!

Name Link
🔨 Latest commit 6af9ea5
🔍 Latest deploy log https://app.netlify.com/sites/developer-chrome-com/deploys/628d2511ba9b9d0008f0ba90
😎 Deploy Preview https://deploy-preview-2892--developer-chrome-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brendankenny
Copy link
Member Author

brendankenny commented May 24, 2022

the package-lock.json change is large, and the vast majority of it looks unrelated to this package.json change. It seems to be rooted in percy, so I assume it's leftovers from #2722 but for whatever reason npm didn't prune package-lock.json correctly at the time 🤷 Always happy to contribute negative lines of code :)

Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this, @brendankenny!

@jeffposnick jeffposnick merged commit f71bbba into main May 26, 2022
@jeffposnick jeffposnick deleted the markdown-it-attrs-bump branch May 26, 2022 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current package.json deps are not compatible with npm v8.8.0+
2 participants