Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Enable workbox-webpack-plugin TSDoc generation #2183

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

jeffposnick
Copy link
Contributor

Fixes #1936

Workbox v6.5.0 includes TypeScript definitions for workbox-webpack-plugin, so we can generate the TSDocs now.

@netlify
Copy link

netlify bot commented Feb 25, 2022

✔️ Deploy Preview for developer-chrome-com ready!

🔨 Explore the source changes: bc01c65

🔍 Inspect the deploy log: https://app.netlify.com/sites/developer-chrome-com/deploys/621929de5eb28e00082a9cfc

😎 Browse the preview: https://deploy-preview-2183--developer-chrome-com.netlify.app

Copy link
Member

@malchata malchata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question, otherwise LGTM!

external/build/workbox-types.js Show resolved Hide resolved
@jeffposnick jeffposnick merged commit 5729986 into main Mar 2, 2022
@jeffposnick jeffposnick deleted the enable-wb-webpack-docs branch March 2, 2022 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable workbox-webpack-plugin type generation
2 participants