Fixes asynch launchTwa freezing splash screens #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved code that builds the splash screen strategy to run on `onCreate()`, so they will already be available when `onEnterAnimationComplete()` is invoked. - When `finish()` is called early, on `onCreate()`, to bring an existing Activity to front, `launchTwa()` shouldn't be invoked. - We update the Firebase demo to reflect that and add a guard in `launcTwa()`.
- Uses an early return in the Firebase demo
PEConn
approved these changes
Jun 7, 2021
Comment on lines
39
to
40
| // The Activity was finished before the launch because an existing instance of | ||
| // the app was brought to front. We don't want to call launchTwa() in this case. |
There was a problem hiding this comment.
I find this comment a little confusing - would you be happy with:
super.onCreate may have called finish, in this case, don't do any work.
|
You guys work fast, thanks for fixing! |
|
Can we bump the version up to include this fix? Thanks! |
|
This has been published on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onCreate(), so they will already be available whenonEnterAnimationComplete()is invoked.finish()is called early, ononCreate(), to bring anexisting Activity to front,
launchTwa()shouldn't be invoked.launchTwa().Closes #281