Fix - Combine stylesheets, Update custom stylesheet link #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Crisner. But I have made some enhancements. So there will be some conflict. Now you can update ur work. |
|
@Soumya44 |
|
Its a risky merge. I'll verify and inform you by evening. Thanks |
|
there may happen some unintentional style property overriding. |
|
Sure. To avoid the risks, I have combined them into a separate stylesheet
called main.css. The old stylesheets have been preserved to revert back if
issues arise. I also had checked the hosted page for any style deviancies
and corrected them. Do take your time to verify.
…On Mon, Mar 26, 2018 at 9:39 AM, Soumya Ranjan Behera < ***@***.***> wrote:
there may happen some unintentional style property overriding.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AcChc4ZvpjVW0SeYr2GYDht8Va2gJfU4ks5tiGoTgaJpZM4S6KmY>
.
|
|
Also, to note, there is an issue with the background being stretched in the secondary pages because of the changes made to the background property of the body of the index page. I had fixed it by adding a class of 'bg' to the body tag of books and quotes pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined stylesheets into main.css
Updated links to the main stylesheet on index.html, books.html and quotes.html
Added a class to the h1 element in books.html and quotes.html to keep previous styling unchanged
Background of index page has a pattern inherited from the other pages, if found to be distracting can be removed by moving it to a class on the books and quotes html files.