-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nonprofit Navigation] Set initial site navigation links #495
Comments
GOO-161 [Nonprofit Navigation] Set initial site navigation links
When a Nonprofit site is first created, the site navigation (header and footer) includes links to all published pages. See #467 and Slack Convo for context. This issue requires that we override the core wp navigation array. Desired When a Nonprofit site is first created, the site navigation (header and footer) should include links to the Auctions page, About GOODBIDS page, and the Login / My Account button. Tasks
|
@nathan-schmidt-viget - Curious if this might be reasonably quick now that we've figured out the default pages stuff? This would be a huge win to get in tomorrow before admin testing! |
@bd-viget so did some more research and it looks like WP is adding an option to render inner blocks inside of
Wonder if we can do something similar. |
Maybe a bit hacking, but found that we can do the mark up in the view like this and it renders. As well as being editable in Gutenberg. Sooooo we could be able to do the same thing and just input our newly created pages.
|
Got this up in a draft PR, two things left to figure out. But it is 90% done! |
* [#495] Setting up basic test with nav links * [#495] testing out pattern for custom menu * [#495] pulling in the created pages into the new nav * [#495] adding notes for TODO * [#495] getting active nav post id * [#495] A couple of tweaks, potential bug fixes * [#495] Some fixes/adjustments * [#495] Used Verified hook for Navigation Changes * [#495] Fix nav + other bug fixes --------- Co-authored-by: Nathan Schmidt <[email protected]>
* [#495] Setting up basic test with nav links * [#495] testing out pattern for custom menu * [#495] pulling in the created pages into the new nav * [#495] adding notes for TODO * [#495] getting active nav post id * [#495] A couple of tweaks, potential bug fixes * [#495] Some fixes/adjustments * [#495] Used Verified hook for Navigation Changes * [#495] Misc Fixes (#591) * [#495] Setting up basic test with nav links * [#495] testing out pattern for custom menu * [#495] pulling in the created pages into the new nav * [#495] adding notes for TODO * [#495] getting active nav post id * [#495] A couple of tweaks, potential bug fixes * [#495] Some fixes/adjustments * [#495] Used Verified hook for Navigation Changes * [#495] Fix nav + other bug fixes --------- Co-authored-by: Nathan Schmidt <[email protected]> --------- Co-authored-by: Brian DiChiara <[email protected]> Co-authored-by: Brian DiChiara <[email protected]>
When a Nonprofit site is first created, the site navigation (header and footer) includes links to all published pages.
See #467 and Slack Convo for context. This issue requires that we override the core wp navigation array.
Desired
When a Nonprofit site is first created, the site navigation (header and footer) should include links to the Auctions page, About GOODBIDS page, and the Login / My Account button.
Tasks
The text was updated successfully, but these errors were encountered: