Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command widget lockup #90

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Fix command widget lockup #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/widgets/nt_widgets/multi-topic/command_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class CommandWidget extends NTWidget {
onTapUp: (_) {
bool publishTopic = model.runningTopic == null;

model.runningTopic =
model.runningTopic ??=
model.ntConnection.getTopicFromName(model.runningTopicName);

if (model.runningTopic == null) {
Expand All @@ -134,6 +134,12 @@ class CommandWidget extends NTWidget {
model.ntConnection.publishTopic(model.runningTopic!);
}

// Prevents widget from locking up if double pressed fast enough
bool running = model.ntConnection
.getLastAnnouncedValue(model.runningTopicName)
?.tryCast<bool>() ??
false;

model.ntConnection
.updateDataFromTopic(model.runningTopic!, !running);
},
Expand Down
Loading