Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dark mode & theme features #65

Merged
merged 8 commits into from
Jul 18, 2024
Merged

added dark mode & theme features #65

merged 8 commits into from
Jul 18, 2024

Conversation

DanPeled
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.03%. Comparing base (8bc547d) to head (fce1b18).

Files Patch % Lines
lib/main.dart 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   45.85%   46.03%   +0.17%     
==========================================
  Files          74       74              
  Lines        7541     7579      +38     
==========================================
+ Hits         3458     3489      +31     
- Misses       4083     4090       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872
Copy link
Owner

Gold872 commented Jul 16, 2024

I think allowing users to change the theme variant is a nice addition, but for adding light mode, I can't find a good color selection that doesn't make the entire app hard to read, as most of the colors used for small decorations (box shadows, dragging highlights, titles, etc) was designed with dark mode in mind. I'll continue playing around with it but I don't know if it will be something I want to include with this PR

@Gold872
Copy link
Owner

Gold872 commented Jul 16, 2024

I was able to get the light mode to look okay-ish, but there's a big issue with having to update all the widgets on the screen whenever the brightness changes, which right now the app isn't really structured to do since not all widgets can be rebuilded on command (which is why many apps require restarting after changing themes).

For now I'll push the changes for the dark mode theming and work from there, what might have to be done is add a pop-up warning the user that the app will have to be restarted for all the theme changes to take effect

@DanPeled
Copy link
Contributor Author

I was able to get the light mode to look okay-ish, but there's a big issue with having to update all the widgets on the screen whenever the brightness changes, which right now the app isn't really structured to do since not all widgets can be rebuilded on command (which is why many apps require restarting after changing themes).

For now I'll push the changes for the dark mode theming and work from there, what might have to be done is add a pop-up warning the user that the app will have to be restarted for all the theme changes to take effect

Ye that makes sense, I didn't really like how the light mode looks how I made it anyway (Not really a fan of light mode, hurts my eyes)

@Gold872
Copy link
Owner

Gold872 commented Jul 17, 2024

Ye that makes sense, I didn't really like how the light mode looks how I made it anyway (Not really a fan of light mode, hurts my eyes)

In that case I suggest removing the light mode feature and have only the theme variant selection feature available

@DanPeled
Copy link
Contributor Author

DanPeled commented Jul 18, 2024

Ye that makes sense, I didn't really like how the light mode looks how I made it anyway (Not really a fan of light mode, hurts my eyes)

In that case I suggest removing the light mode feature and have only the theme variant selection feature available

ill modify this PR then

@Gold872
Copy link
Owner

Gold872 commented Jul 18, 2024

This PR should fix #33

@Gold872 Gold872 merged commit f94a63d into Gold872:main Jul 18, 2024
5 checks passed
@DanPeled DanPeled deleted the themes branch August 31, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants