Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widgets not unsubscribing if type doesn't have a widget implementation #43

Merged
merged 1 commit into from
May 19, 2024

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented May 19, 2024

If you drag a table containing a widget that doesn't have a widget implementation, it will never unsubscribe

This has the widget model be unsubscribed and disposed before returning null in the tree row's toWidgetContainerModel() method

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 45.52%. Comparing base (b719a48) to head (03b2151).

Files Patch % Lines
...b/widgets/network_tree/networktables_tree_row.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   45.54%   45.52%   -0.02%     
==========================================
  Files          73       73              
  Lines        7463     7466       +3     
==========================================
  Hits         3399     3399              
- Misses       4064     4067       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872 Gold872 merged commit 6f61560 into main May 19, 2024
5 checks passed
@Gold872 Gold872 deleted the fix_unknown_type_unsubscribing branch May 19, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant