Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list layout creation for unregistered sendable types #151

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Dec 7, 2024

  • Allows sendables with an unknown/unregistered type to be turned into a list layout
  • Speeds up creation of list layouts
  • Fixes an issue with list layouts not unsubscribing if a drag finishes before list layout is created

Resolves #141

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 77.35849% with 12 lines in your changes missing coverage. Please review.

Project coverage is 66.97%. Comparing base (1a993f3) to head (8aa39be).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...b/widgets/network_tree/networktables_tree_row.dart 57.14% 6 Missing ⚠️
lib/widgets/network_tree/networktables_tree.dart 84.37% 5 Missing ⚠️
lib/services/nt_widget_builder.dart 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   66.67%   66.97%   +0.29%     
==========================================
  Files          78       78              
  Lines        8085     8114      +29     
==========================================
+ Hits         5391     5434      +43     
+ Misses       2694     2680      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872 Gold872 merged commit 8b9f784 into main Dec 7, 2024
8 checks passed
@Gold872 Gold872 deleted the fix-list-layout-creation branch December 7, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sendables not Draggable after beta 1
1 participant