Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Grid Fixes and Cleanup #150

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Tab Grid Fixes and Cleanup #150

merged 4 commits into from
Dec 9, 2024

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Dec 7, 2024

  • Remove refresh() method
  • Listen to state changes for each container model
  • Use setter and getter methods for state notifying fields
  • Remove tab grid field from list layouts

- Remove refresh() method
- Listen to state changes for each container model
- Use setter and getter methods for state notifying fields
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 67.05202% with 57 lines in your changes missing coverage. Please review.

Project coverage is 66.97%. Comparing base (8b9f784) to head (7d581ef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/widgets/tab_grid.dart 58.75% 33 Missing ⚠️
...aggable_containers/draggable_widget_container.dart 40.00% 12 Missing ⚠️
...draggable_containers/models/list_layout_model.dart 56.25% 7 Missing ⚠️
...able_containers/models/widget_container_model.dart 91.22% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   66.97%   66.97%           
=======================================
  Files          78       78           
  Lines        8114     8116    +2     
=======================================
+ Hits         5434     5436    +2     
  Misses       2680     2680           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872 Gold872 merged commit 1c1e92f into main Dec 9, 2024
8 checks passed
@Gold872 Gold872 deleted the fixes-and-cleanup branch December 9, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant