Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed gyro widget to work with doubles #147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NaN0987
Copy link

@NaN0987 NaN0987 commented Nov 30, 2024

The gyro widget can now be applied to single-topic double values. It appears as a display option for doubles, and single-topic gyros will also have all of the display options for doubles.

The gyro widget can now be applied to single-topic double values. It appears as a display option for doubles, and single-topic gyros will also have all of the display options for doubles.
@NaN0987
Copy link
Author

NaN0987 commented Nov 30, 2024

Closes #146

@Gold872
Copy link
Owner

Gold872 commented Dec 1, 2024

I think this is a very useful addition, however I think it could be implemented better

I'd prefer making the widget subscribe only to the topic in the topic property of the json data. This would involve automatically converting existing gyro widgets to set their topic to topic/Value instead of whatever it currently is. It will be a bit of a complicated change but I think it would make a lot of sense to have.

If you want help with any of it I would be willing to write/refactor some of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants