Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera stream edge case error when no image is received #107

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Oct 6, 2024

After disconnecting from network tables, if no image was received from a camera stream, there would be an error due to trying to display an image from an empty cache. This is a fix for it.

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.94%. Comparing base (047d590) to head (b1255aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   63.93%   63.94%           
=======================================
  Files          77       77           
  Lines        7983     7984    +1     
=======================================
+ Hits         5104     5105    +1     
  Misses       2879     2879           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872 Gold872 merged commit 0d609bc into main Oct 6, 2024
5 checks passed
@Gold872 Gold872 deleted the camera-stream-null-fix branch October 6, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant