Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct support for swerve and field widgets #91

Closed
jwbonner opened this issue Sep 4, 2024 · 0 comments · Fixed by #93
Closed

Struct support for swerve and field widgets #91

jwbonner opened this issue Sep 4, 2024 · 0 comments · Fixed by #93
Labels
enhancement New feature or request

Comments

@jwbonner
Copy link

jwbonner commented Sep 4, 2024

I know this has been discussed before, but I think it's worth revisiting.

WPILib is planning to switch to struct publishing for Field2d (see wpilibsuite/allwpilib#6453), so we've agreed to deprecate the double array formats in AdvantageScope this year. It will display a warning when they are used, and you need to manually select the data type and units. The lack of type and unit safety on the double array means that it's very easy for users to use incorrectly, and we continue to see a significant number of support requests for AdvantageScope related to those problems (despite a modern alternative existing).

Adding struct support for these widgets in Elastic doesn't even have to mean full struct decoding (or support for struct descriptors at all). Since the data types are known ahead of time, you just need to read a raw value from NT and pulling out the components at a known offset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant