Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to detect player jump movements #91

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

Malcolmnixon
Copy link
Collaborator

This change fixes issue #85 and consists of:

  • Moving the logic to perform the jump into PlayerBody
  • The one PlayerBody.player_jumped signal now gets called for all jumps (controllers, body, arms)
  • Added function to detect player jump (body and arms)

@BastiaanOlij BastiaanOlij linked an issue Mar 4, 2022 that may be closed by this pull request
@BastiaanOlij BastiaanOlij added this to the 2.4.0 milestone Mar 4, 2022
@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Mar 4, 2022
@BastiaanOlij
Copy link
Member

This looks good to me, worth adding a line to versions.md that we're adding this as its a new feature

@Malcolmnixon Malcolmnixon force-pushed the player-jump-detection branch from 73f7633 to be6c2f7 Compare March 4, 2022 17:10
@BastiaanOlij
Copy link
Member

Really annoying the version thing is causing merge conflicts git can't resolve... probably should do the other PR first, merge that, then rebase this one :)

…Body velocity jumping Modified Jump Detection to support jumping with only the players jump

Moved jumping into PlayerBody. Added function to detect player jump (body and arms).
@Malcolmnixon Malcolmnixon force-pushed the player-jump-detection branch from be6c2f7 to 656263e Compare March 5, 2022 02:30
@BastiaanOlij BastiaanOlij merged commit ecafb44 into GodotVR:master Mar 5, 2022
@Malcolmnixon Malcolmnixon deleted the player-jump-detection branch March 5, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jump movement should be able to be activated by swinging arms up
2 participants