Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function gaze pointer #683

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Function gaze pointer #683

merged 3 commits into from
Oct 5, 2024

Conversation

surreal6
Copy link
Contributor

@surreal6 surreal6 commented Sep 27, 2024 •
edited
Loading

A new implementation of the Gaze Pointer but as an independent function. Based in #664 PR

With 'click on hold' boolean you can select to send clicks to the target node or just move the mouse around.

@surreal6 surreal6 mentioned this pull request Sep 27, 2024
Closed
@Malcolmnixon
Copy link
Collaborator

This is looking very good - although it did highlight a bug with the desktop integration overwriting the headset rotation even in full XR mode - #684

Do you think it's beneficial to keep the laser functionality - it can be enabled and does work, but it looks so bad (the laser coming out between the eyes) I'm not sure it'd ever want to be enabled.

@surreal6
Copy link
Contributor Author

surreal6 commented Oct 3, 2024

Oh, good, you found the bug with the desktop integration. I was unable to detect where it came from, but was suspecting from desktop integration and asked pietru about, but he didn't see any bug...

Yes, i think we can remove the laser functionality. As i understand, It its useful just to check if the pointer is working, but you can also use the target for this. I can remove the laser functionality for clearness.

@surreal6 surreal6 mentioned this pull request Oct 3, 2024
Open
@surreal6
Copy link
Contributor Author

surreal6 commented Oct 3, 2024

this will fix #662 issue

@RangerMauve
Copy link

TY for working on this!

@Malcolmnixon
Copy link
Collaborator

With Pietru's fix this now works perfectly.

Malcolmnixon
Malcolmnixon approved these changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works very well. Nice job

@Malcolmnixon Malcolmnixon added this to the 4.4.0 milestone Oct 5, 2024
@Malcolmnixon Malcolmnixon added the enhancement New feature or request label Oct 5, 2024
@Malcolmnixon Malcolmnixon merged commit 6e3eedb into GodotVR:master Oct 5, 2024
2 checks passed
squidt pushed a commit to squidt/godot-xr-tools that referenced this pull request Nov 17, 2024
@surreal6 @squidt
Function gaze pointer (GodotVR#683)
99421f1 
* function gaze pointer

* hide laser pointer

* remove trailing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malcolmnixon Malcolmnixon Malcolmnixon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@surreal6 @Malcolmnixon @RangerMauve