Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added return-to-snap-zone script #401

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request adds an XRToolsReturnToSnapZone script which returns an XRToolsPickable object to a snap-zone if dropped for longer than a specified duration. Additionally this pull request implements feature #400.

Added return_to_snap_zone script.
@DigitalN8m4r3
Copy link
Contributor

lgtm, no errors now with gdlint when returning to snapzone

Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh this is cool!

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Mar 1, 2023
@BastiaanOlij BastiaanOlij added this to the 3.4.0 milestone Mar 1, 2023
DigitalN8m4r3 added a commit to DigitalN8m4r3/godot-xr-tools that referenced this pull request Mar 1, 2023
backpack model updated
sanp_backpack updated: edited smaller snapzones to scale object that are snapped, this is done by scaling the snapzones parent object
removed beltsnapzones from the pickable scene as they do not work properly

Do Note:
this PR is only useable once the GodotVR#401 PR is merged
the changes right now are not going to work without the above mentioend PR
@Malcolmnixon Malcolmnixon merged commit b251c9e into GodotVR:master Mar 1, 2023
@Malcolmnixon Malcolmnixon deleted the return-to-snap-zone branch March 1, 2023 22:40
DigitalN8m4r3 added a commit to DigitalN8m4r3/godot-xr-tools that referenced this pull request Mar 1, 2023
DigitalN8m4r3 added a commit to DigitalN8m4r3/godot-xr-tools that referenced this pull request Mar 3, 2023
this PR
adds the following to the 4.0 dev branch
- Made XRToolsSnapZone.pick_up_object a public method GodotVR#401
- added basic backpack inventory GodotVR#402
- added tool annotation to snap_zone.gd GodotVR#405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants