Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Snap-zone modes to XRToolsSnapZone #319

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request implements issue #311 by:

  • Modified XRToolsGrabPointSnap so it only allows grabbing from snap-points
  • Modified XRToolsSnapZone to have a snap_mode property
  • Modified XRToolsSnapZone so it snaps dropped objects in range when snap_mode == DROPPED
  • Modified XRToolsSnapZone so it snaps objects in range when snap_mode == RANGE
  • Modified the demo scenes to support the new modes - the saucer is the only RANGE snap-zone

Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm outside of that one nitpick.

…ints Modified XRToolsSnapZone to have a snap_mode property Modified XRToolsSnapZone so it snaps dropped objects in range when snap_mode == DROPPED Modified XRToolsSnapZone so it snaps objects in range when snap_mode == RANGE Modified the demo scenes to support the new modes - the saucer is the only RANGE snap-zone

Applied code review changes for dynamic snap_mode changes.
@Malcolmnixon Malcolmnixon merged commit bac99af into GodotVR:master Jan 8, 2023
@Malcolmnixon Malcolmnixon deleted the snap-on-drop branch January 8, 2023 16:23
@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Jan 9, 2023
@BastiaanOlij BastiaanOlij added this to the 3.2.0 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants