Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed loading and saving of user settings #281

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Fixed loading and saving of user settings #281

merged 1 commit into from
Nov 21, 2022

Conversation

Malcolmnixon
Copy link
Collaborator

The user settings were not being loaded or saved correctly, and would crash if the settings data was corrupt.

BastiaanOlij
BastiaanOlij approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to be merged as a cleanup (well with the introduced bug fixed), but I'm not entirely sure what use case this fixes?

@Malcolmnixon Malcolmnixon merged commit ff304c0 into GodotVR:master Nov 21, 2022
@Malcolmnixon Malcolmnixon deleted the settings-file branch November 21, 2022 01:02
@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Nov 21, 2022
@BastiaanOlij BastiaanOlij added this to the 3.1.0 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Malcolmnixon @BastiaanOlij