Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hand-pose area support #273

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request implements feature request #268 by adding XRToolsFunctionPoseArea and XRToolsHandPoseArea. The function sits under an ARVRController and detects when the hand enters and leaves an XRToolsHandPoseArea. Upon entry the associated poses are set for the hand, and upon exit the poses are removed.

This also fixes a "null" world environment in the main_menu scene.

The following shows a hand near the button getting the Sign Point pose:
image

Added XRToolsFunctionPoseArea to detect hand pose areas and control the hand poses.
Added XRToolsHandPoseArea to define hand poses within an area.
Modified interactables to have hand poses.
Modified poke demo to have a hand pose for touching the screen.
Added pointing to main menu settings UI
…ettings (currently just open/close animations)

Created standard XRToolsHandPoseSettings for standard poses (default and point)
Modified XRToolsHand to set default pose as XRToolsHandPoseSettings
Modified XRToolsHand to maintain priority-sorted list of pose overrides
Modified all hand scenes to use default pose settings
Modified XRToolsHandPoseArea to set pose as XRToolsHandPoseSettings
Modified demo scenes and interactables to use appropriate pose settings
@Malcolmnixon
Copy link
Collaborator Author

The recent update implements pose priorities - to eventually allow grabbed items to override hand-pose areas.

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Nov 18, 2022
@BastiaanOlij BastiaanOlij added this to the 3.1.0 milestone Nov 18, 2022
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing stuff!

@Malcolmnixon Malcolmnixon merged commit d33f5bc into GodotVR:master Nov 18, 2022
@Malcolmnixon Malcolmnixon deleted the hand-pose-function branch November 18, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants