Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes obsolete .blend files and adds seperate blendtrees - currentl… #266

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

DigitalN8m4r3
Copy link
Contributor

…y broken

removed obsolete .blend files since these used the old bone names fixed main menu scene, right hand was set to use nails version added seperate hand_blend_trees for each hand, previously the righthands animationnodetree had for whatever reason old bone names in it as well

Note:
since the merge of the cleanup hands, the animationtree is not visualy loading up a saved out blendtree, however this is not true since it loads it up but does not show its name under the Tree Root since the name is hardcoded in the hand.gd script but if you look close at one of the hand prefab scenes, you will see for example the following ext_resource path="res://addons/godot-xr-tools/hands/animations/left/hand_blend_tree.tres" type="AnimationNodeBlendTree" id=7]

and by uncommenting the tool part of the hand/physics_hand scripts and then loading a hand scene, going to its animationtree, the previous set blendtrees name is visible, therefore the animationtree for the hands is working but the shown name is hardcoded and even by hovering over it, it is not showing if it is a ext resource or not

…y broken

removed obsolete .blend files since these used the old bone names
fixed main menu scene, right hand was set to use nails version
added seperate hand_blend_trees for each hand, previously the righthands animationnodetree had for whatever reason old bone names in it as well

Note:
since the merge of the cleanup hands, the animationtree is not visualy loading up a saved out blendtree, however this is not true since it loads it up but does not show its name under the Tree Root since the name is hardcoded in the hand.gd script but if you look close at one of the hand prefab scenes, you will see for example the following
ext_resource path="res://addons/godot-xr-tools/hands/animations/left/hand_blend_tree.tres" type="AnimationNodeBlendTree" id=7]

and by uncommenting the tool part of the hand/physics_hand scripts and then loading a hand scene, going to its animationtree, the previous set blendtrees name is visible, therefore the animationtree for the hands is working but the shown name is hardcoded and even by hovering over it, it is not showing if it is a ext resource or not
@DigitalN8m4r3 DigitalN8m4r3 marked this pull request as draft November 15, 2022 15:09
@DigitalN8m4r3 DigitalN8m4r3 marked this pull request as ready for review November 16, 2022 00:45
Copy link
Collaborator

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well.

@Malcolmnixon Malcolmnixon merged commit e9ba14f into GodotVR:master Nov 16, 2022
@DigitalN8m4r3 DigitalN8m4r3 deleted the hands-issues-fix branch November 18, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants