Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated alternative hands #262

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

DigitalN8m4r3
Copy link
Contributor

@DigitalN8m4r3 DigitalN8m4r3 commented Nov 14, 2022

this updates the new hand models with the following:

renamed bones to match the OpenXR standard
reworked the lowpoly mesh, since the previous version had too few vertices around the back of the hand added glove materials and models without nails

  • updated with lowpoly mesh fix, restructured prefab scenes into folders

restructured prefab scenes into corresponding folders for high/lowpoly
added additional highpoly glove mesh
fixed ghost material in the climbing scene

Note:
all hand scenes are now loaded as editable children, this way future updates to the mesh wont result in a total rework of the hand scenes

this updates the new hand models with the following:

renamed bones to match the OpenXR standard
reworked the lowpoly mesh, since the previous version had too few vertices around the back of the hand
added glove materials and models without nails
@DigitalN8m4r3
Copy link
Contributor Author

it might look odd that alot got replaced, the reason is simple
as the bones where renamed and additional ones came in as well, the whole tree of saved out anims was useless as it used the old names

regarding the split of the prefab scenes, as it got crowded, it seemed the most logical approach to move the hand prefab scenes into their corresponding folders for high/lowpoly

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Nov 15, 2022
@DigitalN8m4r3
Copy link
Contributor Author

as mentioned on discord, am just wondering what to do with the blendtree, i would save em out for each hand and replace the current animationtree, same i did in the 4.0dev version of the hands

Since the cleanup_hands pr changed some naming, i didnt wanted to touch the animationtrees as they seemed broken but functional. However if i get greenlight to change the animationtrees, gonna do it

Copy link
Collaborator

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well in all scenes and the new layout matches the 4.0-dev which will make porting the new features easier.

@Malcolmnixon Malcolmnixon merged commit 4004c97 into GodotVR:master Nov 15, 2022
@DigitalN8m4r3 DigitalN8m4r3 deleted the update-hands branch November 15, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants