Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move our staging logic into the plugin so it becomes reusable #230

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Move our staging logic into the plugin so it becomes reusable #230

merged 1 commit into from
Oct 27, 2022

Conversation

BastiaanOlij
Copy link
Member

This PR moves most of the staging logic into the plugin. The scene in the demo that is loaded is inherited from the plugin scene.

All that is needed is:

  • setting the start scene
  • adding the ARVROrigin and ARVRCamera nodes, as the setup of this is dependent on the VR interface used, this is not in the base class.

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Oct 26, 2022
@BastiaanOlij BastiaanOlij added this to the 3.1.0 milestone Oct 26, 2022
@BastiaanOlij BastiaanOlij self-assigned this Oct 26, 2022
@BastiaanOlij BastiaanOlij marked this pull request as ready for review October 26, 2022 10:43
@BastiaanOlij BastiaanOlij force-pushed the staging_base branch 3 times, most recently from 8a6bdcb to c754ebc Compare October 27, 2022 01:54
Malcolmnixon
Malcolmnixon approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plays very nicely now.

@BastiaanOlij BastiaanOlij merged commit f31f076 into GodotVR:master Oct 27, 2022
@BastiaanOlij BastiaanOlij deleted the staging_base branch October 27, 2022 02:37
@BastiaanOlij BastiaanOlij linked an issue Nov 5, 2022 that may be closed by this pull request
Provide standard background loading scene #201
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malcolmnixon Malcolmnixon Malcolmnixon approved these changes

Assignees

@BastiaanOlij BastiaanOlij

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Provide standard background loading scene
2 participants
@BastiaanOlij @Malcolmnixon