Renamed files and classes to match new godot-xr-tools standard. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malcolmnixon
force-pushed
the
xr-naming
branch
from
c0161c7 to
e1c72f2
Compare
|
The movement provider instances have filenames of movement_xxx.gd/movement_xxx.tscn; however the classes are XRToolsXxxMovement. The order-change was correctly done for the files to group them easier; however the order-change has not yet been applied to the classes. |
Malcolmnixon
force-pushed
the
xr-naming
branch
from
e1c72f2 to
b539680
Compare
|
Looking good! I think we should consistently name the files according to the class, we can omit XRTools in the filenames. Within Godot the inheritence will group classes by type automatically as movement functions are extended from the movement provider class. |
BastiaanOlij
approved these changes
Sep 26, 2022
… gdlint cleanups. Changes based on code-review and debugging.
Malcolmnixon
force-pushed
the
xr-naming
branch
from
b539680 to
36b15a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #40 by applying the new naming standard. Specifically: