Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure plugin to include a baseline demo #168

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

BastiaanOlij
Copy link
Member

This is our first step to restructuring our repo. This just introduces the base files for our demo. I'll likely merge this as is so I can start working on the CI that creates our deliverables, while Malcolm starts applying a lot of the refactoring.

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Jul 26, 2022
@BastiaanOlij BastiaanOlij added this to the 3.0.0 milestone Jul 26, 2022
@BastiaanOlij BastiaanOlij self-assigned this Jul 26, 2022
@BastiaanOlij BastiaanOlij force-pushed the baseline_300_alpha branch 23 times, most recently from 5314fca to 4be6b2f Compare July 26, 2022 13:03
@BastiaanOlij
Copy link
Member Author

Ok, this is pretty much ready to be merged. On a PR it will now do a build of both the plugin by itself, and the full demo including embedding the OpenXR library.

When tagging it prepares a full release with those two entities.
Here is an example of what that looks like: https://github.com/BastiaanOlij/godot-xr-tools/releases/tag/3.0.0-test

Note that when you examine the zip files they have a root directory, this may seem a bit duplicitous but it is required to publish these zip files on the asset library.

rm -rf demo/godot-xr-tools/.github
- name: Add OpenXR Plugin
run: |
wget --header "Authorization: token ${{ secrets.GITHUB_TOKEN }}" "https://github.com/GodotVR/godot_openxr/releases/download/1.3.0/godot-openxr.zip"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we'll need to hardcode the version of the OpenXR plugin we embed in our demo asset.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works fine for now. I was thinking it could be a build-job variable accessed by the yaml; however I can't find how to set variables through the web; and even if it worked, we might want to have different versions specified for different branches - something embedding in the yaml is capable of achieving.

It does mean we have to update the yaml when the repo wants to jump forwards a rev; but that seems a small price to pay for having the explicit control in branches.

Copy link
Collaborator

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect!

@BastiaanOlij BastiaanOlij merged commit 42c419c into GodotVR:master Jul 27, 2022
@BastiaanOlij BastiaanOlij deleted the baseline_300_alpha branch July 27, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants