Added player height control to support mounting climbed objects and crouching #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
approved these changes
Jun 16, 2022
…ayer to a sphere to allow mounting climbed objects Added crouch movement provider Added advanced player height control Modified climbing to collapse player to a sphere to allow mounting climbed objects Added crouch movement provider Modified height override to use 'self' as per recommendation.
Malcolmnixon
force-pushed
the
climbing-mount-fix
branch
from
9160743 to
882fc56
Compare
|
It should be ready to go in now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements feature requests #143 and #116 with the help of @teddybear082. The changes include:
The PlayerBody now supports:
The math for placing the player body under the camera had to be modified extensively - the original logic would always put the player body on the ARVROrigin floor, whereas the new logic puts the player body under/around the head. This change results in the head/camera always being in the correct position in relationship to the body.